Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixing in FastPrimaryVertex #5832

Merged
merged 4 commits into from Oct 16, 2014

Conversation

silviodonato
Copy link
Contributor

By Martin:

Two bugs:

  1. the fillDescription method ends with the wrong call:
    descriptions.addDefault(desc);
    while it should be something like:
    descriptions.add("jetVertexChecker,desc);

  2. With a fillDescriptions method, you no longer need
    an explicit cfi file in the ../python directory.
    Hence, remove ../python/jetVertexChecker_cfi.py.
    (This is the file currently used by ConfDB parsing).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_3_X.

Bug fixing in FastPrimaryVertex

It involves the following packages:

RecoPixelVertexing/PixelVertexFinding

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @cerati, @GiacomoSguazzoni, @rovere, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@silviodonato
Copy link
Contributor Author

@arizzi

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

(1) Why is addDefault(...) wrong?
(2) You don't delete any file in this PR.

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 5eb060e .
Identical to #5833 (72X) though this one is actually the "original" (well it is the same tag). In both - no diffs observed in jenkins and no other issues.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Oct 16, 2014

Please do not merge this, I'm testing something.

cmsbuild added a commit that referenced this pull request Oct 16, 2014
@cmsbuild cmsbuild merged commit 4f93486 into cms-sw:CMSSW_7_3_X Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants