-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixing in FastPrimaryVertex #5832
Conversation
A new Pull Request was created by @silviodonato for CMSSW_7_3_X. Bug fixing in FastPrimaryVertex It involves the following packages: RecoPixelVertexing/PixelVertexFinding @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
(1) Why is addDefault(...) wrong? |
Please do not merge this, I'm testing something. |
Bug fixing in FastPrimaryVertex
By Martin:
Two bugs:
the fillDescription method ends with the wrong call:
descriptions.addDefault(desc);
while it should be something like:
descriptions.add("jetVertexChecker,desc);
With a fillDescriptions method, you no longer need
an explicit cfi file in the ../python directory.
Hence, remove ../python/jetVertexChecker_cfi.py.
(This is the file currently used by ConfDB parsing).