Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixing in FastPrimaryVertex #5832

Merged
merged 4 commits into from Oct 16, 2014
Merged

Bug fixing in FastPrimaryVertex #5832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f10217b
use descriptions add(....)
silviodonato Oct 15, 2014
4b986a7
BuildFile.xml
silviodonato Oct 15, 2014
70f58ab
BuildFile.xml
silviodonato Oct 15, 2014
5eb060e
BuildFile.xml
silviodonato Oct 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 0 additions & 12 deletions RecoPixelVertexing/PixelVertexFinding/python/jetVertexChecker_cfi.py
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions RecoPixelVertexing/PixelVertexFinding/src/JetVertexChecker.cc
View file
Open in desktop
Expand Up @@ -171,8 +171,6 @@ JetVertexChecker::filter(edm::Event& iEvent, const edm::EventSetup& iSetup)
// ------------ method fills 'descriptions' with the allowed parameters for the module ------------
void
JetVertexChecker::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
//The following says we do not know what parameters are allowed so do no validation
// Please change this to state exactly what you do use, even if it is no parameters
edm::ParameterSetDescription desc;
desc.add<edm::InputTag> ("beamSpot",edm::InputTag("hltOnlineBeamSpot"));
desc.add<edm::InputTag> ("jetTracks",edm::InputTag("hltFastPVJetTracksAssociator"));
Expand All @@ -184,7 +182,7 @@ JetVertexChecker::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
desc.add<double> ("maxChi2",20.0);
desc.add<double> ("maxTrackPt",20.0);
desc.add<bool> ("newMethod",false); // <---- newMethod
descriptions.addDefault(desc);
descriptions.add("jetVertexChecker",desc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous fillDescriptions, using addDefaults
more or less implemented the comment a few lines higher:

//The following says we do not know what parameters are allowed so do no validation
// Please change this to state exactly what you do use, even if it is no parameters

So I guess the comment should also be removed, as now you know exactly what
parameters you want/allow....

}
//define this as a plug-in
DEFINE_FWK_MODULE(JetVertexChecker);