Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muon DQMOffline fix thread un safe #5837

Merged
merged 4 commits into from Oct 17, 2014
Merged

Muon DQMOffline fix thread un safe #5837

merged 4 commits into from Oct 17, 2014

Conversation

folguera
Copy link
Contributor

Removed some unused class (MuonAnalyzerBase) , migrated to support multithread DTsegmentTask and remove thread_unsafe for the EfficiencyAnalyzer (I think is was tagged unsafe by mistake)

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 15, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @folguera (Santiago Folgueras) for CMSSW_7_3_X.

Muon DQMOffline fix thread un safe

It involves the following packages:

DQMOffline/Muon

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@barvic, @battibass, @abbiendi, @bellan, @trocino, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: e466448
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5837/94/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5837/94/summary.html

Dr15Jones
Dr15Jones reviewed Oct 16, 2014
View reviewed changes
DQMOffline/Muon/interface/EfficiencyAnalyzer.h

#include "DQMServices/Core/interface/DQMStore.h"
#include "DQMServices/Core/interface/MonitorElement.h"

class EfficiencyAnalyzer : public thread_unsafe::DQMEDAnalyzer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this module directly or indirectly use the MuonServiceProxy? If so, this needs to remain thread unsafe since the MuonServiceProxy is not safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@folguera this has to remain a thread_unsafe module (thanks @Dr15Jones).
could you please make the change? for the rest the PR looks ok to me.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Oct 16, 2014

+1
thanks @folguera
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
Tested at: 7b83c4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5837/120/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 17, 2014
@nclopezo
Merge pull request #5837 from folguera/MuoDQM-FixThreadUnSafe
a489262 
DQMOffline/Muon -- Muon DQMOffline fix thread un safe
@nclopezo nclopezo merged commit a489262 into cms-sw:CMSSW_7_3_X Oct 17, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5837/120/summary.html

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Oct 21, 2014
@nclopezo
Revert "Merge pull request cms-sw#5837 from folguera/MuoDQM-FixThread…
6971b7b 
…UnSafe"

This reverts commit a489262, reversing
changes made to 7bdc78f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@folguera @cmsbuild @deguio @Dr15Jones @nclopezo