Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_7_0_X] Fix maybe-uninitialized errors in RecoEcal/EgammaClusterAlgos #587

Merged
merged 1 commit into from Aug 22, 2013

Commits on Aug 22, 2013

  1. Fix maybe-uninitialized errors in RecoEcal/EgammaClusterAlgos

    Fix the following two errors on slc6_amd64_gcc481:
    
    RecoEcal/EgammaClusterAlgos/src/PFECALSuperClusterAlgo.cc:276:15: error:
    'IsClusteredWithSeed.{anonymous}::IsClustered::phiwidthSuperCluster_'
    may be used uninitialized in this function [-Werror=maybe-uninitialized]
       IsClustered IsClusteredWithSeed(seed,_clustype,_useDynamicDPhi);
    
    RecoEcal/EgammaClusterAlgos/src/PFECALSuperClusterAlgo.cc:276:15: error:
    'IsClusteredWithSeed.{anonymous}::IsClustered::etawidthSuperCluster_'
    may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    In PFECALSuperClusterAlgo::buildSuperCluster we only check for
    PFLayer::ECAL_BARREL and PFLayer::ECAL_ENDCAP. If any other
    PFLayer::Layer is returned by seed->the_ptr()->layer()
    phiwidthSuperCluster_ and etawidthSuperCluster_ are uninitialized.
    
    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Aug 22, 2013
    Copy the full SHA
    b0ec64d View commit details
    Browse the repository at this point in the history