Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to default HCAL Reco in 73X #5882

Closed
wants to merge 22 commits into from

Conversation

bachtis
Copy link
Contributor

@bachtis bachtis commented Oct 17, 2014

After discussion with HCAL DPG flipping PF to default reconstruction(Method I)
Will commit again when Method II is ready to apply timing cuts.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bachtis for CMSSW_7_3_X.

Switching to default HCAL Reco in 73X

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 17, 2014

My understanding was that Method 2 is comping imminently and is expected to become the default for HCAL.
If that would apply for PF reco, I don't see an immediate reason for this PR.

@bachtis
Copy link
Contributor Author

bachtis commented Oct 17, 2014

Still until this is done HCAL DPG asked to have Method I as the default while now we have Method 1.5 in

@slava77
Copy link
Contributor

slava77 commented Oct 17, 2014

OK.
Do you have any comparison plots to document the changes based on relevant performance plots?
Please post a few, if you have them.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please run tests

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 20, 2014

@bachtis
Michalis, do you have any performance plots showing this change makes things better (or not worse)?

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 31, 2014

Comparisons of this PR with with the current baseline (I'm using CMSSW_7_3_X_2014-10-30-0200 + #6103 for the baseline, and add this PR+enabling method 2). The conclusions are somewhat similar to what I had before: there is a fairly large increase in the number of pf neutral hadrons at low momenta, the absolute response in jets decreases slightly at the highest end of the spectrum.

Other distributions are fairly similar with the current RECO in the release.

dijet QCD 3 to 3.5 TeV
all_test6103_5954-ff7da33_5882-c6e1e97_hbhe2vstest6103_qcd13tevpt3ts3t5wf13p0c_log10recopfcandidates_particleflow__reco_obj_pt50

all_test6103_5954-ff7da33_5882-c6e1e97_hbhe2vstest6103_qcd13tevpt3ts3t5wf13p0c_log10recopfjets_ak4pfjetschs__reco_obj_et

single-mu pt10
all_test6103_5954-ff7da33_5882-c6e1e97_hbhe2vstest6103_singlemupt10wf20p0c_log10recopfcandidates_particleflow__reco_obj_pt50

all_test6103_5954-ff7da33_5882-c6e1e97_hbhe2vstest6103_singlemupt10wf20p0c_log10recopfmets_pfmet__reco_obj_pt

ttbar PU35@25ns
all_test6103_5954-ff7da33_5882-c6e1e97_hbhe2vstest6103_ttbarpuwf25202p0c_log10recopfcandidates_particleflow__reco_obj_pt50

@bachtis
Copy link
Contributor Author

bachtis commented Oct 31, 2014

So @slava77 , you mean this is method 2 vs method 1.5 right ? I assume "what we had in the release" is 72X?
M.

@slava77
Copy link
Contributor

slava77 commented Oct 31, 2014

On 10/31/14, 4:15 PM, bachtis wrote:

So @slava77 https://github.com/slava77 , you mean this is method 2 vs
method 1.5 right ? I assume "what we had in the release" is 72X?
M.

Right


Reply to this email directly or view it on GitHub
#5882 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@slava77
Copy link
Contributor

slava77 commented Nov 3, 2014

Hi Michalis,
Could you please redo your commits on top of #6150
or, maybe simpler, keep just commits in the PF

@bachtis
Copy link
Contributor Author

bachtis commented Nov 3, 2014

Closing -opened new one

@bachtis bachtis closed this Nov 3, 2014
davidlange6 added a commit that referenced this pull request Nov 4, 2014
Default HCAL reco in 73X -> replaces #5882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants