New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exotica dqm update and migration thread safe #5883
Exotica dqm update and migration thread safe #5883
Conversation
…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
A new Pull Request was created by @aescalante (Alberto Escalante del Valle) for CMSSW_7_3_X. Exotica dqm update and migration thread safe It involves the following packages: DQM/Physics @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks. |
Is there a new in this PR? |
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log you can see the results of the tests here: |
Believe this failure is from in unrelated change to ROOT. |
What is the status of this PR? This one it is important because includes the migration to the new multithread interface. |
@@ -82,106 +87,76 @@ | |||
|
|||
class DQMStore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, please remove
hello @aescalante |
Removed unused lines.
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…tion-thread-safe Exotica dqm update and migration thread safe
This branch is a continuation of this one: #5787 (comment). (Sorry for opening a new thread for this PR).
The update wrt the last PR are:
-Migration of the EDAnalyzer to DQMEDAnalyzer as sugested by deguio and Dan in the Twiki. Is possible to test it?? I have tested the code with whiterabbit.py and all the test seem OK, but I dont know if this is enough.
-Then, a considerable reduction of the total number of histograms. Before I had histograms for all the Exotica High Priority Analysis: dijet dilepton and diphoton repated twice for the leading and subleading object and now they are merged into one.
-Information about triggers is also added. This will be fully implemented once the triggers are more defined, but in the current version I only require triggered events.