Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exotica dqm update and migration thread safe #5883

Merged
merged 4 commits into from Oct 27, 2014
Merged

Exotica dqm update and migration thread safe #5883

merged 4 commits into from Oct 27, 2014

Conversation

aescalante
Copy link
Contributor

This branch is a continuation of this one: #5787 (comment). (Sorry for opening a new thread for this PR).

The update wrt the last PR are:
-Migration of the EDAnalyzer to DQMEDAnalyzer as sugested by deguio and Dan in the Twiki. Is possible to test it?? I have tested the code with whiterabbit.py and all the test seem OK, but I dont know if this is enough.

  • Unfortunatly I did not migrate the DQMEDHarvester, but I am not sure if I have to do this for the DQM/Physics/src/ExoticaDQM.h and .cc .

-Then, a considerable reduction of the total number of histograms. Before I had histograms for all the Exotica High Priority Analysis: dijet dilepton and diphoton repated twice for the leading and subleading object and now they are merged into one.

-Information about triggers is also added. This will be fully implemented once the triggers are more defined, but in the current version I only require triggered events.

…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
…tograms + added possibility to validate different type of jets (for dijet HPA) and trigger information for future developments of the module
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aescalante (Alberto Escalante del Valle) for CMSSW_7_3_X.

Exotica dqm update and migration thread safe

It involves the following packages:

DQM/Physics

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@aescalante
Copy link
Contributor Author

Is there a new in this PR?
Thanks,
Alberto.

@cmsbuild
Copy link
Contributor

-1
Tested at: e221c5a
When I ran the RelVals I found an error in the following worklfows:
25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5883/188/summary.html

@Dr15Jones
Copy link
Contributor

Believe this failure is from in unrelated change to ROOT.

@cmsbuild
Copy link
Contributor

@aescalante
Copy link
Contributor Author

What is the status of this PR? This one it is important because includes the migration to the new multithread interface.

@@ -82,106 +87,76 @@

class DQMStore;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, please remove

@deguio
Copy link
Contributor

deguio commented Oct 24, 2014

hello @aescalante
please address my comments. for the DQMEDHarvester migration, you can proceed in parallel. no need to have this PR integrated.
thanks for taking care of this,
F.

Removed unused lines.
@deguio
Copy link
Contributor

deguio commented Oct 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 27, 2014
…tion-thread-safe

Exotica dqm update and migration thread safe
@cmsbuild cmsbuild merged commit 2e58e33 into cms-sw:CMSSW_7_3_X Oct 27, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants