Replace TestRunLumiSource #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Replace TestRunLumiSource It involves the following packages: FWCore/Integration @Dr15Jones, @ktf can you please review it and eventually sign? Thanks. |
|
+1 I did a visual inspection of the code. As long as the test build works this should be merged. |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes. |
|
@nclopezo can you test this? |
|
Hi, I ran the tests on top of CMSSW_7_0_X_2013-08-23-0200, the tests passed. You can see the logs here: |
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Apr 30, 2014
updated for fwlite
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Jan 7, 2016
HeppyCore heppy_loop: pass parser to main function (needed for error printout)
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Jan 10, 2017
fwyzard
added a commit
to fwyzard/cmssw
that referenced
this pull request
Dec 21, 2020
Address the pixel local reconstruction review comments. General clean up of the pixel local reconstruction code: - remove commented out and obsolete code and data members - use named constants more consistently - update variable names to follow the coding rules and for better consistency - use member initializer lists in the constructors - allow `if constexpr` in CUDA code - use `std::size` instead of hardcoding the array size - convert iterator-based loops to range-based loops - replace `cout` and `printf` with `LogDebug` or `LogWarning` - use put tokens - reorganise the auto-generated cfi files and use them more consistently - adjust code after rearranging an `#ifdef GPU_DEBUG` block - apply code formatting - other minor changes Improve comments: - improve comments and remove obsolete ones - clarify comments and types regarding `HostProduct` - update comments about `GPU_SMALL_EVENTS` being kept for testing purposes - add notes about the original cpu code Reuse some more common code: - move common pixel cluster code to `PixelClusterizerBase` - extend the `SiPixelCluster` constructor Rename classes and modules for better consistency: - remove the `TrackingRecHit2DCUDA.h` and `gpuClusteringConstants.h` forwarding headers - rename `PixelRecHits` to `PixelRecHitGPUKernel` - rename SiPixelRecHitFromSOA to SiPixelRecHitFromCUDA - rename `siPixelClustersCUDAPreSplitting` to `siPixelClustersPreSplittingCUDA` - rename `siPixelRecHitsCUDAPreSplitting` to `siPixelRecHitsPreSplittingCUDA` - rename `siPixelRecHitsLegacyPreSplitting` to `siPixelRecHitsPreSplittingLegacy` - rename `siPixelRecHitHostSoA` to `siPixelRecHitSoAFromLegacy` Re-apply changes from cms-sw#29805 that were lost in the Patatrack branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input source TestRunLumiSource, which is used only for testing, is unsuited to the multithreaded framework, and is replaced in this pull request by a new source, ThrowingSource. TestRunLumiSource was formerly used in many unit tests, but its usage was previously replaced in all but two unit tests. One of the two unit tests can easily be modified to use EmptySource. The other test can be handled by a new source, ThrowingSource, which is modeled after EmptySource and conforms to the requirements for the multithreaded framework.
This pull request affects only unit tests. No code used in production is touched.