Make pointers to error strings const in TinyXML #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static analyzer (correctly) pointed to the fact that the array of pointers to the error strings in TinyXML kept one from changing the strings but did not keep one from changing the addresses of the pointers in the array. Making the pointers const solves that problem and guarantees immutability.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X. Make pointers to error strings const in TinyXML It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
core-approved
fully-signed
tests-approved
and removed
comparison-pending
core-approved
fully-signed
tests-pending
labels
nclopezo
added a commit
that referenced
this pull request
Oct 23, 2014
…stInTinyXML FWCore/Utilities -- Make pointers to error strings const in TinyXML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static analyzer (correctly) pointed to the fact that the array of pointers to the error strings in TinyXML kept one from changing the strings but did not keep one from changing the addresses of the pointers in the array. Making the pointers const solves that problem and guarantees immutability.