Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root type system, not interpreter. #5971

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 23, 2014

A fix from Danilo Piparo:
Our AutoLibraryLoader now uses the ROOT interpreter to determine if the dictionary for a class has been loaded.
This is bad in ROOT 6 for two reasons:

  1. A class with a dictionary may be known to the ROOT type system without being known to the interpreter.
  2. Calling the interpreter here may invoke header parsing, which uses a significant amount of memory.
    This simple ROOT6 specific change checks to see if the class is known to the ROOT type system, rather than to the interpreter.
    Please merge this request as soon as convenient.

davidlt added a commit that referenced this pull request Oct 23, 2014
@davidlt davidlt merged commit c25b740 into cms-sw:CMSSW_7_3_ROOT6_X Oct 23, 2014
@wmtan wmtan deleted the UseRootTypeSystemNotInterpreter branch October 23, 2014 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants