Add process history map entry immediately on registration #598
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Add process history map entry immediately on registration It involves the following packages: DataFormats/Provenance @vciulli, @Dr15Jones, @rovere, @ktf, @deguio can you please review it and eventually sign? Thanks. |
|
+1 |
|
The following categories have been signed by ciulli (a.k.a. @vciulli on GitHub): Generators @cms-git-generators |
|
The following categories have been signed by @deguio: DQM @cms-git-dqm |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
|
Can this fully signed request be expedited? it would make life easier if this were already included in an IB. Also, other developments in the near future depend on it. However, this is not critical for pre3, so pre3 comes first. |
|
@wmtan ciao bill. Indeed making sure pre3 was in a good shape is what halted things a bit (together with the fact it got fully signed only yesterday and I was in a course today). If I'll end-up in the same situation in next pre, I think I'll fork off the prerelease candidate, and merge eventual additional changes back one the pre is done). |
|
Closing this one in favor of #640. Test are still running after the merge. |
JEC uncertainty sources
Update the default configuration of "EcalRawToDigiGPU" and "EcalUncalibRecHitProducerGPU": - enable the ECAL pulse timing computation in the offline workflow; - change the ECAL GPU digis label to match the CPU ones. Other clean up: - remove an unused cfi file; - rename "EcalUncalibRecHitMultiFitAlgo_gpu_new" to "EcalUncalibRecHitMultiFitAlgoGPU".
There is a map from ID of the full process history to the ID of the corresponding reduced process history that is stored in the ProcessHistoryRegistry, which is accessible across threads. This map is currently filled in on demand, which means that the registry could be modified during any event, a problem for the multithreaded framework.
This pull request changes this so that an entry is inserted into the map when a process history is registered. This means that the map will no longer, by itself, be a thread safety issue. The ProcessHistoryRegistry as a whole is still an issue.
The changes outside the framework are the minimal adaptations to this framework change.
This request also makes C++ improvements to some of the framework fies that were modified anyway, particularly IndexIntoFIle.cc.