Including DYT algorithm into TuneP and PFMuon #6014
Conversation
|
A new Pull Request was created by @trocino (Daniele Trocino) for CMSSW_7_3_X. Including DYT algorithm into TuneP and PFMuon It involves the following packages: DataFormats/MuonReco @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
| tevTk = muon::tevOptimized(*muon, *trackMapDefault, *trackMapFirstHit, | ||
| *trackMapPicky); | ||
| tevTk = muon::tevOptimized(*muon); | ||
| //tevTk = muon::tevOptimized(*muon, *trackMapDefault, *trackMapFirstHit, |
There was a problem hiding this comment.
is this commented out part needed for imminent development?
If not, please, remove
There was a problem hiding this comment.
This commented line is not needed, we will remove it.
|
Implemented Slava's and Stoyan's comments (thanks!), and added pt>0 checks in few other points in the same code. |
|
Pull request #6014 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again. |
|
@cmsbuild please test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Including DYT algorithm into TuneP and PFMuon
Hi,
this PR is to insert the DYnamic Truncation (DYT) muon refit into the TuneP algorithm, which chooses the best muon track among different refits (originally tracker, global, TPFMS, Picky, now also DYT), according to the track quality. (@rradogna, @ptraczyk)
The output of TuneP (other than being available in reco::Muon as "tunePMuonBestTrack") is passed to the PFMuonAlgo, which can modify the choice by TuneP and select a different track or discard the muon, based on the whole event reconstruction, in particular the effect of the muon on the PF MET. The PFMuonAlgo choice is available in reco::Muon as "muonBestTrack". So also PFMuonAlgo (and PFCandidate) needed some adjustments to handle the new refit type.
In the attached plot by @rradogna, you can see a comparison between the performance of the original TuneP (blue) and the new TuneP with DYT (red) in reconstructing the pt of muons from a SingleMuPt1000 gun sample. The green distribution shows the selected pt between Picky or DYT, when available. It can be seen that the performances of the old and new TuneP are similar, but the new one has less tails (compare RMS, overflow). Note that both DYT and Picky will be further optimized later.
More performance plots from a Zprime(2250) sample can be found here:
http://trocino.web.cern.ch/trocino/Temp/2014-10-27_NewTuneP/
Blue plots are for the old TuneP/PFMuonAlgo, red plots are for the new version. You can see the pt resolution of "tunePMuonBestTrack" (from TuneP) and "muonBestTrack" (from PF) for all muons with a valid inner track ("AllMuons_"), for muons passing the HighPt selection ("HighPtMuons_"), and for muons passing the PFMuon selection ("PFMuons_*"). In all cases, you can see an improvement in the resolution, especially the tails. There's also a PFMET distribution, which looks significantly improved.
@abbiendi, @battibass, @bachtis, @bellan