Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SoftMuon ID selector #6032

Merged
merged 2 commits into from Oct 29, 2014
Merged

Conversation

trocino
Copy link
Contributor

@trocino trocino commented Oct 27, 2014

Hi,
this is an update of the SoftMuon ID selector in
DataFormats/MuonReco/src/MuonSelectors.cc
as described in the Muon POG Twiki:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMuonId#New_Version_recommended.
The optimization of the new working point was carried out by I. Krätschmer, as well as the performance studies:
https://indico.cern.ch/event/277448/material/slides/0?contribId=3
https://indico.cern.ch/event/316122/contribution/3/material/slides/0.pdf.
In few words, the cut on the number of pixel layers is loosened from >1 to >0, the transverse and longitudinal impact parameter cuts are tightened from 3cm to 0.3cm and from 30cm to 20cm, respectively, and the cut on the track chi^2 is replaced by a requirement for the track to be high-purity.
The change does not have any effect at reconstruction level.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @trocino (Daniele Trocino) for CMSSW_7_3_X.

New SoftMuon ID selector

It involves the following packages:

DataFormats/MuonReco

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@abbiendi, @bachtis, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Tested 9bb18c5 on top of CMSSW_7_3_X_2014-10-25-1400, short and extended matrix tests, FWLite and DQM comparisons . Performance is as expected. There are overall more soft muons (both in muon and non-muon /QCD/ datasets). In the barrel they are mostly coming from the removed chi2 cut. There are no other features observed (geometrical or kinematic) for muons. No other effects observed.

wf 20 (muons, pt = 10 GeV):
wf20_chi2_barrel

wf20_chi2_endcap

wf20_chi2_ovl

wf 38 (flat pt QCD):

wf38_pt

@StoyanStoynev
Copy link
Contributor

As usual, red is this PR.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants