New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGC V5 Calibration weights #6039
Conversation
Does there need to be a way to switch between V4 and V5, or are you happy to keep these for everything? |
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC. HGC V5 Calibration weights It involves the following packages: RecoParticleFlow/PFClusterProducer @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@mark-grimes To my understanding the agreement was to simply stop using V4 from this update onwards. |
@mark-grimes @lgray @pfs Yes, we go now with V5 as a baseline (TP) scenario. |
I thought there was a plan for relvals with V4 and V5 at least. @vandreev11? |
@mark-grimes V5 relvals will be enough once the V5 calibrations will be in. |
@mark-grimes I was too quick. V4 relvals will be still good to have as PandoraPFA does their own calibration staring from the RecHits. |
@vandreev11 but this pull request is fine for that? |
@mark-grimes Yes, V5 calibration is applied to PFRecHits, does not disturb RecHits. |
merge Tested and got some root errors which are unrelated, ignoring for now. |
Use October 24th weights from @pfs for HGC V5 geometry.
@vandreev11 - this PR deprecates V4.