Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGC V5 Calibration weights #6039

Merged
merged 1 commit into from Oct 28, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 28, 2014

Use October 24th weights from @pfs for HGC V5 geometry.

@vandreev11 - this PR deprecates V4.

@mark-grimes
Copy link

Does there need to be a way to switch between V4 and V5, or are you happy to keep these for everything?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

HGC V5 Calibration weights

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Oct 28, 2014

@mark-grimes To my understanding the agreement was to simply stop using V4 from this update onwards.

@vandreev11
Copy link
Contributor

@mark-grimes @lgray @pfs Yes, we go now with V5 as a baseline (TP) scenario.

@mark-grimes
Copy link

I thought there was a plan for relvals with V4 and V5 at least. @vandreev11?

@vandreev11
Copy link
Contributor

@mark-grimes V5 relvals will be enough once the V5 calibrations will be in.

@vandreev11
Copy link
Contributor

@mark-grimes I was too quick. V4 relvals will be still good to have as PandoraPFA does their own calibration staring from the RecHits.

@mark-grimes
Copy link

@vandreev11 but this pull request is fine for that?

@vandreev11
Copy link
Contributor

@mark-grimes Yes, V5 calibration is applied to PFRecHits, does not disturb RecHits.

@mark-grimes
Copy link

merge

Tested and got some root errors which are unrelated, ignoring for now.

cmsbuild added a commit that referenced this pull request Oct 28, 2014
@cmsbuild cmsbuild merged commit 520686f into cms-sw:CMSSW_6_2_X_SLHC Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants