Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/L1Trigger -- updated class version to l1extra::L1MuonParticleExtended::StationData #6050

Merged

Conversation

nclopezo
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_6_2_X_SLHC.

DataFormats/L1Trigger -- updated class version to l1extra::L1MuonParticleExtended::StationData

It involves the following packages:

DataFormats/L1Trigger

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Ahh. Sorry, I think this was introduced with this commit. I thought I was fixing checksums, but found out later during integration of #5923 (see comments on outdated diff) that my ~/.rootlogon.C files messes with the checksums.

Probably better to go back to the old checksums than add new ones that are the same as the old ones, but I don't think it makes much difference so it's up to you.
@nclopezo do you want me to do anything or will you handle it? Apologies.

@nclopezo
Copy link
Contributor Author

Hi Mark,
I updated the pull request. Is it ok now?

@mark-grimes
Copy link

Yes, looks good. Sorry for the hassle.

@nclopezo
Copy link
Contributor Author

Ok, I will merge this PR. Tag the release again and start to build it.

nclopezo added a commit that referenced this pull request Oct 28, 2014
DataFormats/L1Trigger -- updated class version to l1extra::L1MuonParticleExtended::StationData
@nclopezo nclopezo merged commit 771a416 into cms-sw:CMSSW_6_2_X_SLHC Oct 28, 2014
@nclopezo nclopezo deleted the update-class-version-62xshlc branch October 28, 2014 15:42
@cmsbuild
Copy link
Contributor

Pull request #6050 was updated. @cmsbuild, @nclopezo, @mulhearn can you please check and sign again.

@nclopezo
Copy link
Contributor Author

I am building the release with this tag:
https://github.com/cms-sw/cmssw/tree/CMSSW_6_2_0_SLHC20

@mark-grimes
Copy link

Out of interest, shouldn't this have made the IBs fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants