Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HO timing monitoring #6052

Merged
merged 1 commit into from Oct 30, 2014
Merged

Fix HO timing monitoring #6052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions DQM/HcalMonitorTasks/interface/HcalDetDiagTimingMonitor.h
View file
Open in desktop
Expand Up @@ -73,10 +73,10 @@ class HcalDetDiagTimingMonitor:public HcalBaseDQMonitor {
return 9999;
}
double get_ped_ho(int eta,int phi,int depth,int cup){
if(nHO[eta+50][phi][depth][cup]<10) return 2.5;
if(nHO[eta+50][phi][depth][cup]<10) return 8.5;
if(nHO[eta+50][phi][depth][cup]!=0){
double ped=HO[eta+50][phi][depth][cup]/nHO[eta+50][phi][depth][cup];
if(ped>1.5 && ped<4.5) return ped;
if(ped>5 && ped<15) return ped;
}
return 9999;
}
Expand Down Expand Up @@ -128,6 +128,8 @@ class HcalDetDiagTimingMonitor:public HcalBaseDQMonitor {
int GCTTriggerBit5_;
bool CosmicsCorr_;

MonitorElement *HBHEShape;
MonitorElement *HOShape;
MonitorElement *HBTimeDT;
MonitorElement *HBTimeRPC;
MonitorElement *HBTimeGCT;
Expand Down
14 changes: 13 additions & 1 deletion DQM/HcalMonitorTasks/src/HcalDetDiagTimingMonitor.cc
View file
Open in desktop
Expand Up @@ -138,6 +138,8 @@ void HcalDetDiagTimingMonitor::setup()
str="HEM Timing (RPCf Trigger)"; HETimeRPCm =dbe_->book1D(str,str,100,0,10);
str="HFP Timing (CSC Trigger)"; HFTimeCSCp =dbe_->book1D(str,str,100,0,10);
str="HFM Timing (CSC Trigger)"; HFTimeCSCm =dbe_->book1D(str,str,100,0,10);
str="HBHE Shape"; HBHEShape =dbe_->book1D(str,str,10,-0.5,9.5);
str="HO Shape"; HOShape =dbe_->book1D(str,str,10,-0.5,9.5);
}
}

Expand Down Expand Up @@ -288,6 +290,11 @@ void HcalDetDiagTimingMonitor::analyze(const edm::Event& iEvent, const edm::Even
for(HBHEDigiCollection::const_iterator digi=hbhe->begin();digi!=hbhe->end();digi++){
eta=digi->id().ieta(); phi=digi->id().iphi(); depth=digi->id().depth(); nTS=digi->size();
for(int i=0;i<nTS;i++) data[i]=adc2fC[digi->sample(i).adc()]-get_ped_hbhe(eta,phi,depth,digi->sample(i).capid());

double energy=0;
for(int i=0;i<nTS;i++) energy+=data[i];
if(energy>20) for(int i=0;i<nTS;i++) HBHEShape->Fill(i,data[i]);

if(!isSignal(data,nTS)) continue;

occHBHE[eta+50][phi][depth]+=1.0; occSum+=1.0;
Expand Down Expand Up @@ -317,7 +324,12 @@ void HcalDetDiagTimingMonitor::analyze(const edm::Event& iEvent, const edm::Even
for(HODigiCollection::const_iterator digi=ho->begin();digi!=ho->end();digi++){
eta=digi->id().ieta(); phi=digi->id().iphi(); depth=digi->id().depth(); nTS=digi->size();
for(int i=0;i<nTS;i++) data[i]=adc2fC[digi->sample(i).adc()]-get_ped_ho(eta,phi,depth,digi->sample(i).capid());
if(!isSignal(data,nTS)) continue;

double energy=0;
for(int i=0;i<nTS;i++) energy+=data[i];
if(energy>100) for(int i=0;i<nTS;i++) HOShape->Fill(i,data[i]);
if(energy<100) continue;

occHO[eta+50][phi][depth]+=1.0;
occSum+=1.0;
if((occHO[eta+50][phi][depth]/(double)(ievt_))>0.001) continue;
Expand Down
4 changes: 4 additions & 0 deletions DQM/Integration/python/test/hcal_dqm_sourceclient-live_cfg.py
View file
Open in desktop
Expand Up @@ -194,6 +194,10 @@
if (HEAVYION):
process.hcalHotCellMonitor.ETThreshold = cms.untracked.double(10.0)
process.hcalHotCellMonitor.ETThreshold_HF = cms.untracked.double(10.0)

if process.runType.getRunType() == process.runType.cosmic_run:
process.hcalDetDiagTimingMonitor.CosmicsCorr=True


# Don't create problem histograms for tasks that aren't run:
process.hcalClient.enabledClients = ["DeadCellMonitor",
Expand Down