fix layer condition in HGCalDDDConstants::newCell()

[jbsauvan]

No description provided.

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for CMSSW_6_2_X_SLHC.

fix layer condition in HGCalDDDConstants::newCell()

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

Do you know the before and after effects of this fix in terms of performance?
Just so we know what changes to expect in validation.

[mark-grimes]

@jbsauvan, @vandreev11
Is this required for HGCal GEN-SIM production?

[jbsauvan]

Hi Mark,
It fixes the up/down navigation in HGCal, which was not working properly. But it is not used in the clustering, so it shouldn't change any physics performance.

[vandreev11]

@mark-grimes @pfs @bsunanda Mark, wait with this. This needs to be tested. It can not go into the imminent release.
@jbsauvan Jean-Baptiste, you need to inform HGCAL software coordinators (Pedro Silva and Valeri Andreev) of any modification/fixes. Little change can have a huge impact on the release.
@grimes Not approved yet.

[mark-grimes]

Okay, too late for the release anyway. Just announced here.

[pfs]

@mark-grimes @vandreev11 @bsunanda It's ok. This is a minor correction it's only used at analysis level at this point

[vandreev11]

+1

[mark-grimes]

Getting a very strange GEN-SIM crash in scenarios other than HGCal. Not entirely sure it's because of this pull request because it only happens when combined with other pull requests, but the crash is in the DetectorDescription deconstruction and this is the only one that changes anything close to that. Also the combination of pull requests that causes it doesn't appear to be consistent, so very difficult to pinpoint. Trying to track it down.

Stack trace for workflow 10000 (crashes right at the end of GenSim):

#5  arena_run_reg_dalloc (ptr=0x7fcd57e0b080, run=0x7fcd57e07000) at src/arena.c:2703
#6  arena_dalloc_bin (arena=0x7fcd7c840a80, chunk=0x7fcd57e00000, ptr=0x7fcd57e0b080, mapelm=<optimized out>) at src/arena.c:1858
#7  0x00007fcd7f35485b in arena_dalloc (ptr=0x7fcd57e0b080, chunk=0x7fcd57e00000, arena=0x7fcd7c840a80) at include/jemalloc/internal/arena.h:707
#8  idalloc (ptr=0x7fcd57e0b080) at include/jemalloc/internal/jemalloc_internal.h:712
#9  free (ptr=0x7fcd57e0b080) at src/jemalloc.c:1409
#10 0x00007fcd77606b8e in __gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<std::pair<std::string, std::string> const, int> > >::deallocate (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __p=0x7fcd57e0b080) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/ext/new_allocator.h:100
#11 0x00007fcd77606212 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_put_node (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __p=0x7fcd57e0b080) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:373
#12 0x00007fcd77604eda in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_destroy_node (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __p=0x7fcd57e0b080) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:420
#13 0x00007fcd77603f79 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_erase (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __x=0x7fcd57e0b080) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:1084
#14 0x00007fcd77603f56 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_erase (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __x=0x7fcd57e09cc0) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:1082
#15 0x00007fcd77603f56 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_erase (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __x=0x7fcd57e09a40) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:1082
#16 0x00007fcd77603f56 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_erase (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __x=0x7fcd57e95700) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:1082
#17 0x00007fcd77603f56 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::_M_erase (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __x=0x7fcd58319b80) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:1082
#18 0x00007fcd77603178 in std::_Rb_tree<std::pair<std::string, std::string>, std::pair<std::pair<std::string, std::string> const, int>, std::_Select1st<std::pair<std::pair<std::string, std::string> const, int> >, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::~_Rb_tree (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __in_chrg=<optimized out>) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_tree.h:646
#19 0x00007fcd77602650 in std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > >::~map (this=0x7fcd776ebd40 <DDI::Singleton<std::map<std::pair<std::string, std::string>, int, std::less<std::pair<std::string, std::string> >, std::allocator<std::pair<std::pair<std::string, std::string> const, int> > > >::instance()::value>, __in_chrg=<optimized out>) at /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/external/gcc/4.7.2-cms/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_map.h:90
#20 0x00007fcd7e10db32 in exit () from /lib64/libc.so.6
#21 0x00007fcd7e0f6d64 in __libc_start_main () from /lib64/libc.so.6
#22 0x000000000040eb91 in _start ()

[Dr15Jones]

I suggest using valgrind to see if something else is deleting the memory.

[mark-grimes]

I think I've found the issue in #6059. It was deleting a random section of memory so the fact that the stack trace mentioned DDI::Singleton was a red herring.

[mark-grimes]

merge