New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HB radiation damage model #6059
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC. HB radiation damage model It involves the following packages: CalibCalorimetry/HcalPlugins @civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @rcastello, @cerminar, @mmusich can you please review it and eventually sign? Thanks. |
@@ -375,6 +379,7 @@ HCalSD::~HCalSD() { | |||
if (showerPMT) delete showerPMT; | |||
if (showerBundle) delete showerBundle; | |||
if (m_HEDarkening) delete m_HEDarkening; | |||
if (m_HBDarkening) delete m_HBDarkening; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is causing very bizarre crashes in several workflows. Gen-Sim is crashing right at the end of the job, I'd post the stacktrace but I think it's irrelevant.
Since m_HBDarkening is not set to zero at the start, if ageingFlagHB is not used then this will delete a random section of memory.
I have a fix ready, I'll test and then put in a new pull request.
Pull request #6059 with a fix to memory handling
This commit introduces a radiation damage model for HB, based on a very rough extrapolation from the HE radiation damage model (as described in the comments of HBDarkening.cc). The associated recalibration is also introduced, using the same method as HE. The implementation includes a "scenario" parameter like the one recently introduced for HEDarkening, to allow for easy addition of HB scintillator replacement scenarios in the future. HB darkening currently is not turned on by default, but must be activated by manually adding set_HB_aging_scenario to the config file. (This may be changed in the near future).
This commit also fixes a small bug introduced in #3207 which assigned the wrong depth segmentation to towers 16 and 17 when calculating the HE recalibration. The effect of this bug on aging simulations would have been negligible.