Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HB radiation damage model #6059

Merged
merged 4 commits into from Nov 3, 2014
Merged

Conversation

kpedro88
Copy link
Contributor

This commit introduces a radiation damage model for HB, based on a very rough extrapolation from the HE radiation damage model (as described in the comments of HBDarkening.cc). The associated recalibration is also introduced, using the same method as HE. The implementation includes a "scenario" parameter like the one recently introduced for HEDarkening, to allow for easy addition of HB scintillator replacement scenarios in the future. HB darkening currently is not turned on by default, but must be activated by manually adding set_HB_aging_scenario to the config file. (This may be changed in the near future).

This commit also fixes a small bug introduced in #3207 which assigned the wrong depth segmentation to towers 16 and 17 when calculating the HE recalibration. The effect of this bug on aging simulations would have been negligible.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

HB radiation damage model

It involves the following packages:

CalibCalorimetry/HcalPlugins
DataFormats/HcalCalibObjects
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HcalSimProducers
SimG4CMS/Calo
SimG4Core/Application

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @rcastello, @cerminar, @mmusich can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -375,6 +379,7 @@ HCalSD::~HCalSD() {
if (showerPMT) delete showerPMT;
if (showerBundle) delete showerBundle;
if (m_HEDarkening) delete m_HEDarkening;
if (m_HBDarkening) delete m_HBDarkening;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is causing very bizarre crashes in several workflows. Gen-Sim is crashing right at the end of the job, I'd post the stacktrace but I think it's irrelevant.
Since m_HBDarkening is not set to zero at the start, if ageingFlagHB is not used then this will delete a random section of memory.
I have a fix ready, I'll test and then put in a new pull request.

@mark-grimes
Copy link

Superseded by #6175. Please close and move the discussion there (if not this should close automatically when #6175 is merged).

@cmsbuild cmsbuild merged commit ef78ad1 into cms-sw:CMSSW_6_2_X_SLHC Nov 3, 2014
cmsbuild added a commit that referenced this pull request Nov 3, 2014
Pull request #6059 with a fix to memory handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants