Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safe access to HCAL conditions containers #6060

Merged

Conversation

Dr15Jones
Copy link
Contributor

Modified how HCAL conditions containers are used in order to be thread safe. The setTopo method of the containers is now non-const. Therefore to fully initialize a container read from the database, the container is copied and the copy gets the setTopo call. This copy is either done via an ESProducer or, for less used containers, by the module which requested the original container.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Thread safe access to HCAL conditions containers

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CaloOnlineTools/HcalOnlineDb
CondFormats/HcalObjects
CondTools/Hcal
DQM/HcalMonitorClient
DQM/HcalMonitorTasks
DQMOffline/Hcal
RecoEgamma/EgammaHLTProducers
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoMET/METFilters
RecoMET/METProducers
RecoMuon/MuonIdentification
RecoParticleFlow/PFClusterProducer
SimCalorimetry/HcalSimAlgos
Validation/HcalRecHits

@diguida, @cerminar, @Martin-Grunewald, @rcastello, @perrotta, @civanch, @cmsbuild, @fwyzard, @mdhildreth, @rovere, @deguio, @slava77, @ggovi, @vadler, @mmusich, @ojeda, @mulhearn, @apfeiffer1, @nclopezo, @danduggan, @monttj, @StoyanStoynev can you please review it and eventually sign? Thanks.
@TaiSakuma, @battibass, @abbiendi, @mmarionncern, @lgray, @bellan, @nhanvtran, @schoef, @mariadalfonso, @argiro, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 29, 2014

+1

for #6060 6d8e44a
tested in CMSSW_7_3_X_2014-10-28-1400 (test area sign449)
no differences in monitored quantities, looking at just at the shorter set of matrix tests

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

everything was approved before the rebase, so pushing in - please post any issues we missed to this PR.

davidlange6 added a commit that referenced this pull request Oct 31, 2014
Thread safe access to HCAL conditions containers
@davidlange6 davidlange6 merged commit e90a418 into cms-sw:CMSSW_7_3_X Oct 31, 2014
@Dr15Jones Dr15Jones deleted the makeHcalContainersThreadSafe branch November 4, 2014 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet