Renamed edm::Selections to edm::SelectedProducts #607
Conversation
We early had a name conflict between ::Selections and edm::Selections. To avoid such a problem in the future, I've renamed edm::Selections to edm::SelectedProducts to better describes its purpose.
|
+1 LXR showed that these were the only places where edm::Selections and edm::SelectionsArray were used. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Renamed edm::Selections to edm::SelectedProducts It involves the following packages: DataFormats/Provenance @demattia, @rcastello can you please review it and eventually sign? Thanks. |
|
Short matrix test results available at: |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
Renamed edm::Selections to edm::SelectedProducts
The CUDAService already checks for the availability of a suitable GPU at job startup, so there is no need to explicitly disable it in the python configuration. This fixes the case where the configuration is expanded or pickled on a machine without GPUs, and then run on a machine with a GPU: in this case the CUDAService gets incorrectly disabled, breaking the configuration itself.
The CUDAService already checks for the availability of a suitable GPU at job startup, so there is no need to explicitly disable it in the python configuration. This fixes the case where the configuration is expanded or pickled on a machine without GPUs, and then run on a machine with a GPU: in this case the CUDAService gets incorrectly disabled, breaking the configuration itself.
We early had a name conflict between ::Selections and edm::Selections.
To avoid such a problem in the future, I've renamed edm::Selections to
edm::SelectedProducts to better describes its purpose.