Alpha T DQM module for 73X

[aelwood]

Split up the alphaT HLT DQM module and HLT Filter into two new pull requests (as suggested in #6003 ). Rearranged the HLTrigger/JetMET module slightly to allow for the use of the AlphaT class in other modules

[cmsbuild]

A new Pull Request was created by @aelwood for CMSSW_7_3_X.

Alpha T DQM module for 73X

It involves the following packages:

HLTrigger/JetMET
HLTriggerOffline/SUSYBSM

@perrotta, @cmsbuild, @nclopezo, @danduggan, @rovere, @Martin-Grunewald, @deguio, @fwyzard, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Martin-Grunewald]

There is a compilation error:

tmp/slc6_amd64_gcc481/src/HLTriggerOffline/SUSYBSM/src/HLTriggerOfflineSUSYBSM/SUSY_HLT_alphaT.o: In function `SUSY_HLT_alphaT::analyze(edm::Event const&, edm::EventSetup const&)':
SUSY_HLT_alphaT.cc:(.text+0x1758): undefined reference to `AlphaT::value_(std::vector<bool, std::allocator<bool> >*) const'
SUSY_HLT_alphaT.cc:(.text+0x211f): undefined reference to `AlphaT::value_(std::vector<bool, std::allocator<bool> >*) const'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc6_amd64_gcc481/src/HLTriggerOffline/SUSYBSM/src/HLTriggerOfflineSUSYBSM/libHLTriggerOfflineSUSYBSM.so] Error 1
gmake: *** Waiting for unfinished jobs....
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[aelwood]

Error should be fixed now. I forgot to include the JetMET module in the SUSYBSM build file...

[cmsbuild]

Pull request #6089 was updated. @perrotta, @cmsbuild, @nclopezo, @danduggan, @rovere, @Martin-Grunewald, @deguio, @fwyzard, @ojeda can you please check and sign again.

[cmsbuild]

+1
Tested at: 6f84a51
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6089/498/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6089/498/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[deguio]

@aelwood
this PR triggers spurious printouts.. refer for example to:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6298/764/DQMTestsResults/DQMTestsResults/3/p3.4.log

are these paths going to be available soon in the menu? can this behaviour be fixed in the meantime?
thanks,
F.

[aelwood]

@deguio
The paths are in the latest HLT and GRUN confDB:
/dev/CMSSW_7_2_1/HLT/V103
/dev/CMSSW_7_2_1/GRun/V48

If you want in the mean time I can remove the error message? I'm not sure the best way to go about fixing it other than that.

Cheers,
Adam

[perrotta]

@aelwood , @deguio

Sorry to jump in, but I don't think that DQm should trigger error
messages (or, even worse, crashes) in case some HLT path supposed to
be monitored is actually missing. Please take into account that in the
"real life" we will use this code to run on events taken with several
possible different menus (1.4e34, 7e33, low lumi, heavy ions, ...),
and the paths to be monitored will not necessarily be present there
every time. Probably a more convenient way for realizing that a given
path is missing must be found...

(my 2 cents)

aelwood notifications@github.com ha scritto:

@deguio
The paths are in the latest HLT and GRUN confDB:
/dev/CMSSW_7_2_1/HLT/V103
/dev/CMSSW_7_2_1/GRun/V48

If you want in the mean time I can remove the error message? I'm not
sure the best way to go about fixing it other than that.

Cheers,
Adam

---

Reply to this email directly or view it on GitHub:
#6089 (comment)

[deguio]

a first step could be to downgrade the messages from errors to warnings.
it would be nice to understand in which configuration the paths will be missing... I let you guys decide which is the best option to minimize the noise in the logs.

from the DQM code side, we don't want to fill up the logs if it is not needed.

F.

[aelwood]

@deguio
I have made a new PR, changing these from errors to warnings as you suggested. #6366

I based this DQM module on others in the SUSYBSM package, hence the format.

Please let me know if I should change anything else