Convert HcalRealisticZS to stream module #6092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HcalRealisticZS uses the HcalDbService which the static analyzer
has complained about because of that object's use of the HCAL
conditions containers. However, upon further investigation the HcalDbService
is thread safe for this use. In addition, an upcoming change to
the conditions containers will solve the remaining thread unsafe uses
of those containers.
With that in mind, it is safe to convert HcalRealisticZS to a stream module.