Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert HcalRealisticZS to stream module #6092

Merged
merged 1 commit into from Oct 29, 2014

Conversation

Dr15Jones
Copy link
Contributor

The HcalRealisticZS uses the HcalDbService which the static analyzer
has complained about because of that object's use of the HCAL
conditions containers. However, upon further investigation the HcalDbService
is thread safe for this use. In addition, an upcoming change to
the conditions containers will solve the remaining thread unsafe uses
of those containers.
With that in mind, it is safe to convert HcalRealisticZS to a stream module.

The HcalRealisticZS uses the HcalDbService which the static analyzer
has complained about because of that object's use of the HCAL
conditions containers. However, upon further investigation the HcalDbService
is thread safe for this use. In addition, an upcoming change to
the conditions containers will solve the remaining thread unsafe uses
of those containers.
With that in mind, it is safe to convert HcalRealisticZS to a stream module.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Convert HcalRealisticZS to stream module

It involves the following packages:

SimCalorimetry/HcalZeroSuppressionProducers

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Oct 29, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 29, 2014
Convert HcalRealisticZS to stream module
@cmsbuild cmsbuild merged commit 6f945c9 into cms-sw:CMSSW_7_3_X Oct 29, 2014
@Dr15Jones Dr15Jones deleted the streamHcalRealisticZS branch November 4, 2014 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants