Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for candidate-based TagInfos in pat::Jet #6099

Conversation

ferencek
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Added support for candidate-based TagInfos in pat::Jet

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ferencek ferencek force-pushed the CandTagInfoForPatJets_from-CMSSW_7_3_X_2014-10-29-1400 branch from d84f1c9 to e362b4c Compare October 30, 2014 04:26
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #6099 was updated. @vadler, @monttj can you please check and sign again.

@vadler
Copy link

vadler commented Oct 30, 2014

@ferencek : Could you please move the templates' implementation to the header file -- including the already existing tagInfoByType?

@ferencek
Copy link
Contributor Author

@vadler sure, I can do that.

@ferencek
Copy link
Contributor Author

@vadler ok, templates moved.

@cmsbuild
Copy link
Contributor

Pull request #6099 was updated. @cmsbuild, @vadler, @nclopezo, @monttj can you please check and sign again.

return 0;
}

template<typename T> const T * tagInfoByTypeAndLabel(const std::string &label="") const
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this is rather a tagInfoByTypeOrLabel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Updated to tagInfoByTypeOrLabel

@vadler
Copy link

vadler commented Oct 31, 2014

+1
Tested on top of CMSSW_7_3_X_2014-10-29-1400.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Oct 31, 2014
…CMSSW_7_3_X_2014-10-29-1400

Added support for candidate-based TagInfos in pat::Jet
@cmsbuild cmsbuild merged commit d560bee into cms-sw:CMSSW_7_3_X Oct 31, 2014
@ferencek ferencek deleted the CandTagInfoForPatJets_from-CMSSW_7_3_X_2014-10-29-1400 branch December 24, 2014 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants