New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for candidate-based TagInfos in pat::Jet #6099
Added support for candidate-based TagInfos in pat::Jet #6099
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X. Added support for candidate-based TagInfos in pat::Jet It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
d84f1c9
to
e362b4c
Compare
@ferencek : Could you please move the templates' implementation to the header file -- including the already existing |
@vadler sure, I can do that. |
@vadler ok, templates moved. |
return 0; | ||
} | ||
|
||
template<typename T> const T * tagInfoByTypeAndLabel(const std::string &label="") const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this is rather a tagInfoByTypeOrLabel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Updated to tagInfoByTypeOrLabel
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…CMSSW_7_3_X_2014-10-29-1400 Added support for candidate-based TagInfos in pat::Jet
@arizzi