Hydjet2Interface

[wouf]

This is Hydjet2 for CMSSW_7_3_X

[cmsbuild]

A new Pull Request was created by @wouf for CMSSW_7_3_X.

Hydjet2Interface

It involves the following packages:

GeneratorInterface/Hydjet2Interface

The following packages do not have a category, yet:

GeneratorInterface/Hydjet2Interface

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: d2e0031
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6135/563/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6135/563/summary.html

[cbaus]

Is this really needed? I don't see anything in the code that uses root

[cbaus]

Alright now I discovered the use of TLorentzVector and some TMath functions. Sorry for that.

[davidlange6]

@ktf - @nclopezo - @Degano - please add this package to GEN category

[nclopezo]

Done here: cms-sw/cms-bot@a325440

[davidlange6]

@wouf - could you address the compiler warning we see due to this IB asap. Thanks

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc491/CMSSW_7_3_X_2014-11-04-1400/GeneratorInterface/Hydjet2Interface

[wouf]

@davidlange6 - this warning coming from fortran part of Hydjet2:
GeneratorInterface/Hydjet2Interface/src/progs_fortran.f:342:0: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
if(i.le.150000)then

[davidlange6]

i know where it is coming from - I wanted it fixed…Thanks

On Nov 5, 2014, at 11:08 AM, wouf notifications@github.com
wrote:

@davidlange6 - this warning coming from fortran part of Hydjet2:
GeneratorInterface/Hydjet2Interface/src/progs_fortran.f:342:0: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
if(i.le.150000)then

—
Reply to this email directly or view it on GitHub.

[wouf]

@davidlange6 - done, fortran warning was fixed. Have I recreate the pull request?
@cbaus - convertation from couts to LogInfo for warnings, errors and info prints, would be done soon

[davidlt]

@wouf where was it fixed? I continue to see warning:

  /build/cmsbuild/jenkins-workarea/workspace/build-any-ib/1714/w/tmp/BUILDROOT/aa9ce9e8b2a686f91971bd9cefd00c62/opt/cmssw/slc6_amd64_gcc481/cms/cmssw-patch/CMSSW_7_3_X_2014-11-10-0200/src/GeneratorInterface/Hydjet2Interface/src/progs_fortran.f:342:0: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized]
          if(i.le.150000)then 
 ^

Looking at the code the problem is here:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_3_X/GeneratorInterface/Hydjet2Interface/src/progs_fortran.f#L325

If nhsel is not equal to zero, then you define i (I think, not sure how scopes work in Fortran)

[davidlt]

@wouf log: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_3_X_2014-11-10-0200/GeneratorInterface/Hydjet2Interface

[wouf]

I mean I fixed it here https://github.com/wouf/cmssw/tree/CMSSW_7_3_X/GeneratorInterface/Hydjet2Interface
So, I have to create new pull request?

[davidlt]

Correct, the change happened after a merge. Thus a new PR needs to created with additional changes (i.e. the fix) after merge point.

[wouf]

thanks, done