added configurable parameters maxAssocCaloE and maxAssocCaloEDeltaRSize

[jbrinson]

These configurable parameters calculate the associated calorimeter energy associated with a track (i.e. the sum of all calo tower deposits within a cone around the track)

[cmsbuild]

A new Pull Request was created by @jbrinson for CMSSW_7_3_X.

added configurable parameters maxAssocCaloE and maxAssocCaloEDeltaRSize

It involves the following packages:

RecoTracker/DeDx

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: bff3feb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6168/597/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6168/597/summary.html

[slava77]

why this try /catch? This should be removed.
Isn't the name of the collection known?

The CaloTowers should also be declared in the consumes part
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMGetDataFromEvent

[Dr15Jones]

My personal opinion is getManyByType is evil and wasteful.

[jbrinson]

Hi Slava,

Could you tell me what you mean by 'The CaloTowers should also be declared
in the consumes part'? Do you mean to declare it here:

inputTracksTag_ = iConfig.getParameter< edm::InputTag > ("inputTracksTag");

inputdedxTag_ = iConfig.getParameter< edm::InputTag > ("inputDeDxTag");

inputTracksToken_ = consumesreco::TrackCollection(iConfig.getParameter<
edm::InputTag > ("inputTracksTag"));

inputdedxToken_ = consumesedm::ValueMap<reco::DeDxData >(iConfig.
getParameter< edm::InputTag > ("inputDeDxTag"));

Or maybe you could tell me what section of the twiki page you are referring
to?

Thank you so much for taking the time to look at this!

Cheers,

Jessica Brinson

On Mon, Nov 3, 2014 at 3:03 PM, Slava Krutelyov notifications@github.com
wrote:

In RecoTracker/DeDx/plugins/HLTDeDxFilter.cc:

@@ -144,6 +148,38 @@ bool
double relTrkIso = (ptCone - pt[i])/(pt[i]);
if (relTrkIso > maxRelTrkIsoDeltaRp3_) continue;
}
+

•   //calculate the calorimeter energy associated with the track if maxAssocCaloE_ >= 0
  

•   if(maxAssocCaloE_ >= 0){
  

•   // Copy code from:  http://cmslxr.fnal.gov/lxr/source/DataFormats/CaloTowers/test/CaloTowersDump.cc
  

•   // See reference:  https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCaloTowers
  

•   std::vectoredm::Handle<CaloTowerCollection > prods;
  

•   try {
  

•     iEvent.getManyByType(prods);
  

why this try /catch? This should be removed.
Isn't the name of the collection known?

The CaloTowers should also be declared in the consumes part
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMGetDataFromEvent

—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/6168/files#r19733699.

[slava77]

Hi Jessica,

Yes, the constructor should have consumes<CaloTowerCollection>...

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6168/650/summary.html

[slava77]

+1

for #6168 b77e313
jenkins compiled ok, code updates visually ok

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.