Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonMonitoring fixes for 7_2_X #6203

Merged
merged 6 commits into from Nov 7, 2014
Merged

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Nov 4, 2014

Changes:

  • output_X.jsd file name and path as hltd expects
  • making sure to write ini file at first seen lumisection in each process

*output_*.jsd name and path as hltd expects
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2014

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_2_X.

JsonMonitoring fixes for 7_2_X

It involves the following packages:

EventFilter/Utilities
HLTrigger/JSONMonitoring

@perrotta, @cmsbuild, @nclopezo, @emeschi, @Martin-Grunewald, @fwyzard, @mommsen can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

Remember to make a PR for 73X as well - in fact, there is #6105 already (previous round) - still not signed by DAQ.

@smorovic
Copy link
Contributor Author

smorovic commented Nov 4, 2014

Good point. We first need to get #6105 merged - or Aram could also add this commit to it.

@avetisya
Copy link
Contributor

avetisya commented Nov 4, 2014

I've added this commit to #6105 .

@emeschi
Copy link
Contributor

emeschi commented Nov 4, 2014

+1
On 04 Nov 2014, at 17:51, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

A new Pull Request was created by @smorovichttps://github.com/smorovic (Srecko Morovic) for CMSSW_7_2_X.

JsonMonitoring fixes for 7_2_X

It involves the following packages:

EventFilter/Utilities
HLTrigger/JSONMonitoring

@perrottahttps://github.com/perrotta, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @emeschihttps://github.com/emeschi, @Martin-Grunewaldhttps://github.com/Martin-Grunewald, @fwyzardhttps://github.com/fwyzard, @mommsenhttps://github.com/mommsen can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezohttps://github.com/nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6203#issuecomment-61672392.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@Martin-Grunewald
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

Please also put this latest change into 73!

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @davidlange6, @smuzaffar

@smorovic
Copy link
Contributor Author

smorovic commented Nov 6, 2014

I made the 73X PR: #6243

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants