Add support for noticing and complaining about removed plugins. #6220
Conversation
This introduces the concept of a poisoned Plugin Cache File which will contain dummy (wrong) entries for all plugins which should be build built given a local area. If those plugins are actually there, nothing is changed since the local cache file has precedence. If the plugin was not built, e.g. it was removed in the local area, the plugin manager will complain about not finding the dummy entry. This patch alone will not introduce any change in behavior and will require scram to generate the poison file in order to turn on the new functionality.
ktf
force-pushed
the
poison-plugin-cache
branch
from
9f25516
to
273a8c1
Compare
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_3_X. Add support for noticing and complaining about it removed plugins. It involves the following packages: FWCore/PluginManager @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
ktf
changed the title
|
-1 Tested at: 273a8c1 ---> test testFWCoreFWLite had ERRORS you can see the results of the tests here: |
|
@ktf I think this might have been caused by a race codition in the Jenkin's testing system since the problem stems from a temporary file being missing when it came time for it to be ready |
|
@nclopezo, can you rerun the tests? |
|
FWCore/FWLite/test/ref_t.cppunit.cpp creates it in 'setUp' and then uses it in its tests. So it can't be a race in the test itself. |
|
Well, actually RefTest.sh deletes it, right? I wonder if somehow it's possible the driver does not wait for the execpl of RefTest.sh to return and so you have something deleting it after it has been created. Anyways, will look more if it happens again.. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Add support for noticing and complaining about removed plugins.
This introduces the concept of a poisoned Plugin Cache File which will
contain dummy (wrong) entries for all plugins which should be built
given a local area. If those plugins are actually there, nothing is
changed since the local cache file has precedence. If the plugin was not
built, e.g. it was removed in the local area, the plugin manager will
complain about not finding the library specified by the dummy entry.
This patch alone will not introduce any change in behavior and will
require scram to generate the poison file in order to turn on the new
functionality.