Remove usage of HcalCholeskyMatrix in simulation, and propagate this to the new Global Tags for pre2 RelVal.

[diguida]

HcalCholeskyMatrix payloads are touched by a ROOT5 streamer bug in serialisation. As temporary workaround, we remove their usage in simulation, falling back to the old description of the noise, as agreed with @Dr15Jones at the last ORP.

New set of Global Tags in view of second pre-release of 73X release cycle.

• Run1 and Run2 simulations:
  • added DYTThresholdObject payloads with dummy values as currently in configuration, in order to consume them properly from the GT. The values are different for Run1 and Run2 as they account for different geometries. No changes expected for Muon POG
  • removed HcalCholeskyMatrices payloads.
• Run1 and Run2 data:
  • added DYTThresholdObject payloads with dummy values as currently in configuration, in order to consume them properly from the GT. The values are different for Run1 and Run2 as they account for different geometries. No changes expected for Muon POG.

[cmsbuild]

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_3_X.

New Global Tags for pre2 RelVal.

It involves the following packages:

Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[diguida]

@battibass @trocino this allows you to remove the loading of the DYT threshold values currently used from configuration files. In case you have the PR ready, you are welcome to cherry-pick this commit and add yours on top: I will close this PR as superseded.

[diguida]

Short matrix tests on CMSSW_7_3_X_2014-11-05-1400 IB are ok:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Nov  5 21:04:08 2014-date Wed Nov  5 20:59:53 2014; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Nov  5 21:15:15 2014-date Wed Nov  5 20:59:57 2014; exit: 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Wed Nov  5 21:03:08 2014-date Wed Nov  5 21:00:00 2014; exit: 0 0
8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Nov  5 21:04:41 2014-date Wed Nov  5 21:00:02 2014; exit: 0 0 0 0 0
25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Nov  5 21:16:30 2014-date Wed Nov  5 21:03:16 2014; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Wed Nov  5 21:12:14 2014-date Wed Nov  5 21:04:10 2014; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Nov  5 21:10:10 2014-date Wed Nov  5 21:04:44 2014; exit: 0 0 0 0
7 7 6 6 4 tests passed, 0 0 0 0 0 failed

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

[cmsbuild]

-1
Tested at: 847da09
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 05-Nov-2014 22:04:29 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 05-Nov-2014 22:04:38 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'local_digireco'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 05-Nov-2014 22:04:50 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 05-Nov-2014 22:05:30 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 05-Nov-2014 22:08:04 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 5 event: 12001
   [1] Running path 'simulation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 05-Nov-2014 22:11:03 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 05-Nov-2014 22:11:29 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 05-Nov-2014 22:14:24 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
No "HcalCholeskyMatricesRcd" record found in the EventSetup.
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6224/673/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing).

[diguida]

@davidlange6 @ktf I am confused.
As you can see in my previous comment, I ran the limited matrix on the latest IB, and it was ok, see in particular 5.1, 8.0, 25.0. What is wrong with my local tests?

[civanch]

+1

[diguida]

From the comparisons:

• 4.22: no changes, as expected
• 4.53: some minimal changes for reco::Tracks produced by module tevMuons/dyt for process reRECO
• 5.1: no changes
• 8.0: no changes
• 25.0: no changes
• 101.0: no changes
• 1000.0: some minimal changes for reco::Tracks produced by module tevMuons/dyt for process reRECO
• 1001.0: no changes, as expected.

[diguida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.