Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types of event/run/lumi in Jet/MET (for fastjet) #6229

Conversation

StoyanStoynev
Copy link
Contributor

The online is changing to produce data with event numbers that are 64 bits instead of 32 bits. CMSSW software needs to be modified to handle that. Following
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1302.html
I am making changes to different packages, here JET/MET for fastjet usage. Changing the types in fastjet would be a longer process so I just explicitly cast to the supported type (the run/event numbers are used as random seeds - there should be no practical problem here). Updates are generally trivial and there should be no any visible effects of them (except for the rare event numbers with > 32 bits).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

A new Pull Request was created by @StoyanStoynev for CMSSW_7_3_X.

Update types of event/run/lumi in Jet/MET (for fastjet)

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @nhanvtran, @mariadalfonso, @TaiSakuma, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@StoyanStoynev
Copy link
Contributor Author

+1
I tested f73f9a9 on top of CMSSW_7_3_X_2014-11-04-0200 - no diffs (despite some variations seen in jenkins) and none expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 6, 2014
…3_X_2014-11-04-0200

Update types of event/run/lumi in Jet/MET (for fastjet)
@cmsbuild cmsbuild merged commit dfae65c into cms-sw:CMSSW_7_3_X Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants