Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim* Packages -- changes for large object passed by value #624

Merged
merged 1 commit into from Sep 10, 2013
Merged

Sim* Packages -- changes for large object passed by value #624

merged 1 commit into from Sep 10, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Aug 26, 2013

found by clang static analyzer cms.ArgSizeChecker

std::vector
edm::ParameterSet

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

Sim* Packages -- changes for large object passed by value

It involves the following packages:

SimDataFormats/CaloHit
SimRomanPot/SimFP420
SimGeneral/GFlash
SimG4Core/SensitiveDetector
SimTracker/TrackerMaterialAnalysis
SimCalorimetry/EcalTrigPrimAlgos
SimG4CMS/FP420
SimTracker/TrackerFilters
SimDataFormats/CrossingFrame
SimTracker/TrackAssociation
SimG4CMS/Forward
SimG4Core/Geometry
SimGeneral/MixingModule
SimDataFormats/JetMatching
SimTracker/SiStripDigitizer
SimG4CMS/Calo
SimMuon/MCTruth
SimG4CMS/ShowerLibraryProducer

@civanch, @mdhildred, @giamman can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@giamman
Copy link
Contributor

giamman commented Aug 26, 2013

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Aug 28, 2013

+1

@nclopezo
Copy link
Contributor

nclopezo commented Sep 3, 2013

Hi,

I ran the usual tests for this pull request on top of CMSSW_7_0_X_2013-09-03-0200, all tests passed.

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/371/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/371/

ktf added a commit that referenced this pull request Sep 10, 2013
Sim* Packages -- changes for large object passed by value
@ktf ktf merged commit 4a79d94 into cms-sw:CMSSW_7_0_X Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants