Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Hlt integration, 1.4e34 menu for Run II #6263

Merged

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Nov 7, 2014

CMSHLT-153 (single muon paths for SMP) to master and GRun
CMSHLT-159 (Integration of HTXXX paths in 73X) in master and GRun
CMSHLT-160 (New tau paths) in master and GRun
CMSHLT-162 (update of muon paths) to master
CMSHLT-164 (razor paths) to master and GRun

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_7_3_X.

Hlt integration, early morning of Nov 7, 2014

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@geoff-smith this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

Pull request #6263 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2014

This Pull Request needs having also #6214 integrated in advance, otherwise DQM tests of some of the newly integrated HLT paths may crash

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

-1
Tested at: 860a34a
When I ran the RelVals I found an error in the following worklfows:
1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6263/726/summary.html

@jalimena
Copy link
Contributor Author

jalimena commented Nov 7, 2014

@cmsbuild The errors in these two files are indeed the ones you get if you do not have #6214, as @perrotta mentioned earlier.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2014

I am ready to say "+1", but #6214 must be merged first...

@davidlange6
Copy link
Contributor

hold

in any case - we need reasonable PR titles for these.

On Nov 7, 2014, at 2:03 PM, perrotta notifications@github.com
wrote:

I am ready to say "+1", but #6214 must be merged first...


Reply to this email directly or view it on GitHub.

@jalimena jalimena changed the title Hlt integration, early morning of Nov 7, 2014 Additional Hlt integration, 1.4e34 menu for Run II Nov 7, 2014
@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2014

@davidlange6 : we are integrating HLT paths several times per day, and we are short of titles.
You can find a quite exhaustive description of the PR content anyhow, though...

@jalimena
Copy link
Contributor Author

jalimena commented Nov 7, 2014

Is the title better now? Sorry, we've had a lot of these in the past few days, I thought I should keep track in the title of when it was submitted.

@davidlange6
Copy link
Contributor

unfortunately it is "what" is integrated rather than "when" that is most useful for release notes. This is better, though something more descriptive than "additional" could be helpful when appropriate

On Nov 7, 2014, at 2:21 PM, Juliette Alimena notifications@github.com
wrote:

Is the title better now? Sorry, we've had a lot of these in the past few days, I thought I should keep track in the title of when it was submitted.


Reply to this email directly or view it on GitHub.

@perrotta
Copy link
Contributor

perrotta commented Nov 7, 2014

+1
#6214 now merged in 73X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 7, 2014
Additional Hlt integration, 1.4e34 menu for Run II
@cmsbuild cmsbuild merged commit cf3ac7f into cms-sw:CMSSW_7_3_X Nov 7, 2014
@jalimena jalimena deleted the hltIntegration1p4e34Run2_11072014 branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants