Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon regional iterative tracking in default HI reco #6279

Merged
merged 22 commits into from Nov 14, 2014

Conversation

yetkinyilmaz
Copy link
Contributor

Including the muon regional iterative tracking in the default heavy ion reconstruction. From @echapon and @mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_3_X.

Muon regional iterative tracking in default HI reco

It involves the following packages:

RecoHI/HiMuonAlgos
RecoHI/HiTracking

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 7, 2014

Hi Yetkin

Please describe the physics and technical (CPU and such) effects of this PR.
If there were some slides presented in an HI meeting, a link to the slides would be very useful.
This is for self-documentation purpose.

Thank you.

@mandrenguyen
Copy link
Contributor

Hello Slava,

This is the feature presented on slide 4 and 5 from the RECO meeting on
July 31st:
https://indico.cern.ch/event/330432/

Cheers,
Matt

On 11/7/14 9:26 PM, Slava Krutelyov wrote:

Hi Yetkin

Please describe the physics and technical (CPU and such) effects of
this PR.
If there were some slides presented in an HI meeting, a link to the
slides would be very useful.
This is for self-documentation purpose.

Thank you.


Reply to this email directly or view it on GitHub
#6279 (comment).


Matthew Nguyen
Chargé de Recherche
LLR-Ecole Polytechnique
91128 Palaiseau FRANCE

+33 1 69 33 55 65

@@ -29,8 +29,8 @@
'keep recoTrackExtras_reglobalMuons_*_*',
'keep recoTracks_retevMuons_*_*',
'keep recoTrackExtras_retevMuons_*_*',
'keep recoTrackExtras_hiGeneralAndRegitMuTracks_*_*',
'keep recoTracks_hiGeneralAndRegitMuTracks_*_*',
# 'keep recoTrackExtras_hiGeneralAndRegitMuTracks_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove, don't comment out

@yetkinyilmaz
Copy link
Contributor Author

That's a good idea.
@echapon can you add the slides?

On 11/7/14 9:26 PM, Slava Krutelyov wrote:

Hi Yetkin

Please describe the physics and technical (CPU and such) effects of
this PR.
If there were some slides presented in an HI meeting, a link to the
slides would be very useful.
This is for self-documentation purpose.

Thank you.


Reply to this email directly or view it on GitHub
#6279 (comment).

@echapon
Copy link
Contributor

echapon commented Nov 8, 2014

regitmu1
regitmu2

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2014

Pull request #6279 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2014

+1

#6279 3a8c59e
tested in CMSSW_7_3_X_2014-11-07-0200 (test area sign454)

the standalone muons are back.
The rest is the same as already summarized above.

The 140.53 (on 400 events) has a CPU increase of about 3s/event (about 1.5% increase) on average, coming from the hiRegitMu

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
Muon regional iterative tracking in default HI reco
@cmsbuild cmsbuild merged commit 4a80e5b into cms-sw:CMSSW_7_3_X Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants