Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize HCAL aging functions #6284

Merged
merged 1 commit into from Nov 10, 2014
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Nov 7, 2014

This commit reorganizes the HCAL aging functions to separate the aging customizations for HB, HE, HF, and SiPMs. Important notes:

  • The default behavior of the function ageHcal remains unchanged (HB aging is not enabled by default).
  • Several pre-defined function snippets are added to change the HE aging scenarios easily via the cmsDriver --customise command: turn_on_HE_aging_X for scenario X (currently 1, 2, or 3).
  • SiPM aging can now be separately disabled.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

reorganize HCAL aging functions

It involves the following packages:

CalibCalorimetry/HcalPlugins
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @rcastello, @cerminar, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fratnikov
Copy link

merge

cmsbuild added a commit that referenced this pull request Nov 10, 2014
reorganize HCAL aging functions
@cmsbuild cmsbuild merged commit 55471d4 into cms-sw:CMSSW_6_2_X_SLHC Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants