Misc memory related fixes. #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No need for check the ptr to be different than 0 when using delete: delete 0 is a noop. - Fix minor leak, reported by valgrind and in CMSSW since ~ever, where a new [] was not followed by a delete[].
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X. Misc memory related fixes. It involves the following packages: HLTriggerOffline/Higgs @rovere, @deguio can you please review it and eventually sign? Thanks. |
|
The following categories have been signed by @rovere: DQM @cms-git-dqm |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
perrozzi
pushed a commit
to perrozzi/cmssw
that referenced
this pull request
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete 0 is a noop.
where a new [] was not followed by a delete[].