Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73X - fix Heppy GCC4.9.1 compilation warnings #6330

Merged

Conversation

vadler
Copy link

@vadler vadler commented Nov 11, 2014

Add (empty) default constructors to heppy::Hemisphere and heppy::HemisphereViaKt to be used in Reflex dictionary creation.

…sphereViaKt to be used in Reflex dictionary creation.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_3_X.

73X - fix Heppy GCC4.9.1 compilation warnings

It involves the following packages:

PhysicsTools/Heppy

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link
Author

vadler commented Nov 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 11, 2014
73X - fix Heppy GCC4.9.1 compilation warnings
@davidlange6 davidlange6 merged commit 6912b9a into cms-sw:CMSSW_7_3_X Nov 11, 2014
@vadler vadler deleted the 73X-fixHeppyCompilationWarning branch November 11, 2014 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants