Use correct function argument #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X. Use correct function argument It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
db-approved
fully-signed
tests-pending
and removed
comparison-pending
db-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_ROOT6_X IBs unless changes or unless it breaks tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many conditions unit tests are segfaulting because of a bug in the ROOT6 specific Conditions code. TVirtualCollectionProxy::GetFunctionNext(bool) must be called here with an argument of false rather than the default argument value of true.
This pull request eliminates the segfault, but most of the affected tests will still fail later due to different problems that are revealed by this pull request, but not caused by it.
Please merge this request as soon as convenient.