Replace boost::{bind,cref,ref} with std:: version; C++11 compliant #6353
Conversation
Boost 1.53.0 modified their `cref/ref` to match C++11 standard. Remove dependency on boost and use standard library features. According to C++ standard you are not allowed to use `cref/ref` with rvalues. In this particular case you are not allowed to pass `e.streamID()` as a reference. I think, `std::reference_wrapper` is not allowed to hold a reference to a temporary, otherwise it would be undefined behavior. Details: http://wg21.cmeerw.net/lwg/issue688 Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_3_X. Replace boost::{bind,cref,ref} with std:: version; C++11 compliant It involves the following packages: Mixing/Base @cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks. |
|
I don't want to stop this from being merged, but I think (not 100% sure) that std::ref(_this) and std::cref(_this), when used right after the function in the std::bind of a member function, are sub-optimal. A simple "this" would be much better. All the use of ref or cref does is, at most, to save the copying of a pointer, and it may not even do that. The cost is a function call and more complex code. |
|
I only made minimal changes, I kept them as-is. |
|
I think I'll leave this alone for now. If "std::(c)ref(*this)" is changed to "this", it should be done separately from any boost->std conversion. |
|
Since we are talking about 'style', I think it would probably be clearer to replace all of these *::bind with C++11 lambdas. |
|
Ok with me. As long as we go back and revisit this for optimisation. Someone help me remember to do that... |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Replace boost::{bind,cref,ref} with std:: version; C++11 compliant
Boost 1.53.0 modified their
cref/refto match C++11 standard. Removedependency on boost and use standard library features. According to C++
standard you are not allowed to use
cref/refwith rvalues. In thisparticular case you are not allowed to pass
e.streamID()as areference. I think,
std::reference_wrapperis not allowed to hold areference to a temporary, otherwise it would be undefined behavior.
Details: http://wg21.cmeerw.net/lwg/issue688
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch