Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synch xmls between 62XSLHC dev and 73X (upgrade phase1 and phase2 Tracker) #6354

Merged
merged 11 commits into from Nov 12, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Nov 12, 2014

continuing the cleaning/synchronization with 62XSLHC :

  • For Phase2 : ExtendedPhase2TkBE5DPixel10D is the only phase2 tracker scenario supported (phase2 Tracker + extendedPixel)
    So, I removed evything like ExtendedPhase2TkBE5D, PixelForward etc...and put the xml for ExtendedPhase2TkBE5DPixel10D + config files
    The xml are in PhaseII/Pixel10D/ as they were already defined in 62XSLHC.

In addition new developments for phase1 xml (Geometry/TrackerCommonData/data/PhaseI/trackerStructureTopology.xml) has been taken into account.

For the moment not a single working workflow is using these geometries (this is to a preliminary step to make it run actually)

@venturia: I included your xml files from your branch in this PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_7_3_X.

Synch xmls between 62XSLHC dev and 73X (upgrade phase1 and phase2 Tracker)

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerSimData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor Author

boudoul commented Nov 12, 2014

I originally forgot the RecoMaterial directory , I just updated my PR to fix this

@cmsbuild
Copy link
Contributor

Pull request #6354 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@ianna
Copy link
Contributor

ianna commented Nov 12, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 12, 2014
Synch xmls between 62XSLHC dev and 73X (upgrade phase1 and phase2 Tracker)
@cmsbuild cmsbuild merged commit b6387d3 into cms-sw:CMSSW_7_3_X Nov 12, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@boudoul
Copy link
Contributor Author

boudoul commented Nov 14, 2014

@mark-grimes : just to keep him informed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants