Do not declare class in template instantiation; add missing header

[davidlt]

The package contains two files, which cause Clang to abort (assert):

• PhysicsTools/PatUtils/plugins/SmearedJetProducer.cc
• PhysicsTools/PatUtils/plugins/SmearedPATJetProducer.cc

After long investigation I stopped here:

corrJetP4 =
std::is_base_of<class PATJetCorrExtractor, Textractor>::value ?
  jetCorrExtractor_(jet, jetCorrLabel_.label(), jetCorrEtaMax_, &rawJetP4) :
  jetCorrExtractor_(jet, jetCorr.product(), jetCorrEtaMax_, &rawJetP4);

PATJetCorrExtractor was nowhere to be found in the translation unit.
We have a class declaration in template instantion.

The patch removes such declaration and includes a header (from the same
package), which declares and defines PATJetCorrExtractor.

Resolves both Clang aborts.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_3_X.

Do not declare class in template instantiation; add missing header

It involves the following packages:

PhysicsTools/PatUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @acaudron, @mmarionncern, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 3bcdb40
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6365/839/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6365/839/summary.html

[vadler]

+1
Tested with CMSSW_7_3_X_2014-11-13-0200.
Purely technical change. No regressions expected and non observed with PhysicsTools/PatAlgos/test/patTuple_metUncertainties_cfg.py

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.