Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fixing of b-tag validation code. #6368

Merged
merged 20 commits into from Nov 13, 2014
Merged

Conversation

silviodonato
Copy link
Contributor

Bug-fixing of b-tag validation code, using HLT_PFMET120_NoiseCleaned_BTagCSV07 instead of HLT_PFMET170.

In very few events it happened that HLT_PFMET170_NoiseCleaned_v1 pass, but no b-tag variables were reconstructed (although HLT_PFMET120_NoiseCleaned_BTagCSV07_v1 use lower threshold).
This because HLT_PFMET120_NoiseCleaned_BTagCSV07 use also a cut on "hltMETCleanUsingJetID80".

Now, I select only events that pass HLT_PFMET120_NoiseCleaned_BTagCSV07, so we have BTag variables for sure.

Silvio.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_3_X.

Bug-fixing of b-tag validation code.

It involves the following packages:

HLTriggerOffline/Btag
HLTriggerOffline/Common

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@silviodonato
Copy link
Contributor Author

@cmsbuild

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Nov 13, 2014

mmm.. what you mean with bug fixing? it seems to me that a whole new packages is added with this PR..

F.

@deguio
Copy link
Contributor

deguio commented Nov 13, 2014

ok.. now I remember. the original PR was reverted because caused crashes.
#5904

@deguio
Copy link
Contributor

deguio commented Nov 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 13, 2014
Bug-fixing of b-tag validation code.
@cmsbuild cmsbuild merged commit 9f302eb into cms-sw:CMSSW_7_3_X Nov 13, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants