Misc errors and warnings cleanup in DQMOffline/Trigger #6377
Conversation
The path resolves the following errors:
error: address of 'this->triggerResults_' will always evaluate to
'true' [-Werror,-Wpointer-bool-conversion]
Taking an address of `triggerResults_` and implicitly converting to bool
will always yield true.
I believe author wanted `triggerResults_.isValid()`.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
`HLTTauDQMOfflineObjects` is declared as a struct in `DQMOffline/Trigger/interface/HLTTauDQMPath.h`. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
The patch resolves all -Wunused-private-field generated warnings:
private field '???' is not used [-Wunused-private-field]
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
The patch corrects struct forwarding. `CutMasks` and `BinData` are structs, not classes. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Based on `DQMStore` Doxygen documentation, `Nmin_` and `Nmax_` must be
double. Otherwise the numbers are changed by implicit `double` to `int`
conversion.
JetMETHLTOfflineSource.cc:1593:27: warning: implicit conversion from
'double' to 'int' changes value from 0.5 to 0 [-Wliteral-conversion]
JetMETHLTOfflineSource.cc:1594:26: warning: implicit conversion from
'double' to 'int' changes value from 9.5 to 9 [-Wliteral-conversion]
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_3_X. Misc errors and warnings cleanup in DQMOffline/Trigger It involves the following packages: DQMOffline/Trigger @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks. |
cmsbuild
added
comparison-available
dqm-pending
pending-signatures
and removed
comparison-pending
dqm-pending
pending-signatures
tests-approved
labels
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
…ne-Trigger Misc errors and warnings cleanup in DQMOffline/Trigger
The following patchset cleanups all Clang reported errors and majority of reported warnings. Warnings from RooFit were fixed today for future 5.34.XX patch releases.
This is needed to compile with Clang.
Please, review.