Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new function TEnum::GetQualifiedName() #6382

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 13, 2014

In order to fix a problem causing a failing unit test (PhysicsTools/PatAlgos), a new ROOT function, TEnum::GetQualifiedName() was needed, as well as some other ROOT changes.
As part of the fix, CMSSW needs to call the new function. This pull request replaces an obsoleted call with a call to the new function.
Please merge this request for the same IB in which ROOT6 is being updated to the HEAD of the patches branch, as the changes are mutually dependent.
If this request is merged without updating ROOT6, a compilation error will result.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

Use new function TEnum::GetQualifiedName()

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Nov 13, 2014
@davidlt davidlt merged commit 0665e02 into cms-sw:CMSSW_7_3_ROOT6_X Nov 13, 2014
@davidlt
Copy link
Contributor

davidlt commented Nov 13, 2014

Goes together with cms-sw/cmsdist#1183

@wmtan wmtan deleted the UseNewFunctionTEnumGetQualifiedName branch November 24, 2014 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants