Cleanup of refVector() and ptrVector() calls to edm::View<T>

[ferencek]

Cleanup of refVector() and ptrVector() calls to edm::View. This is a follow-up to #6245.

@Dr15Jones @arizzi

[Dr15Jones]

+1

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

Cleanup of refVector() and ptrVector() calls to edm::View

It involves the following packages:

CommonTools/CandAlgos
DPGAnalysis/Skims
DataFormats/Common
EgammaAnalysis/ElectronTools
FWCore/Framework
MuonAnalysis/MuonAssociators
PhysicsTools/IsolationAlgos
PhysicsTools/SelectorUtils
PhysicsTools/TagAndProbe
RecoEcal/EgammaClusterAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/ElectronIdentification
RecoTauTag/TauTagTools
SimMuon/MCTruth
Validation/RecoMuon

@civanch, @nclopezo, @StoyanStoynev, @vlimant, @danduggan, @rovere, @monttj, @cmsbuild, @franzoni, @mdhildreth, @deguio, @slava77, @vadler, @ojeda, @davidlange6 can you please review it and eventually sign? Thanks.
@jpavel, @battibass, @wmtan, @abbiendi, @wddgit, @argiro, @bellan, @lgray, @trocino, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

   [1] Running path 'validation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociation'
Exception Message:
In VectorHolder<T, REFV> trying to push_back wrong reference type 

[cmsbuild]

-1
Tested at: 8745b32
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 14-Nov-2014 05:04:05 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'prevalidation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociationFS'
Exception Message:
In VectorHolder trying to push_back wrong reference type 
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 14-Nov-2014 05:11:48 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 5 event: 12001
   [1] Running path 'prevalidation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociationFS'
Exception Message:
In VectorHolder trying to push_back wrong reference type 
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 14-Nov-2014 05:14:26 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociation'
Exception Message:
In VectorHolder trying to push_back wrong reference type 
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 14-Nov-2014 05:14:42 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociation'
Exception Message:
In VectorHolder trying to push_back wrong reference type 
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log
----- Begin Fatal Exception 14-Nov-2014 05:32:35 CET-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step'
   [2] Calling event method for module MuonAssociatorEDProducer/'tpToTkMuonAssociation'
Exception Message:
In VectorHolder trying to push_back wrong reference type 
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6385/870/summary.html

[ferencek]

Can this be pushed through?

[slava77]

@vadler @mdhildreth @civanch
we need your signatures here.
Please check and report if there are any issues.
Thank you.

[civanch]

But unit tests have some problem?

[ferencek]

@civanch Chris already commented that the unit test failure was unrelated to the code changes in this PR.

[vadler]

+1
Tested with CMSSW_7_3_X_2014-11-17-0200

[davidlange6]

sim changes are trivial - bypassing