Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make static theVerboseLevel const #6392

Merged

Conversation

Dr15Jones
Copy link
Contributor

The file static variable theVerboseLevel has no way of being changed
via code therefore it is safe to make it const. This avoids complaints
from the static analyzer.

The file static variable theVerboseLevel has no way of being changed
via code therefore it is safe to make it const. This avoids complaints
from the static analyzer.
@Dr15Jones
Copy link
Contributor Author

This variable was being accessed by a stream module so removing the static analyzer complaint makes it easier to find real problems.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Make static theVerboseLevel const

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 15, 2014

+1

for #6392 b635263
kind of trivial, and jenkins agrees

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 15, 2014
@cmsbuild cmsbuild merged commit 80318bd into cms-sw:CMSSW_7_3_X Nov 15, 2014
@Dr15Jones Dr15Jones deleted the makeGlobalConstSiPixelTemplateReco branch January 23, 2015 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants