Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed and deprecated Boost.Signals header #6399

Merged
merged 1 commit into from Nov 14, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Nov 14, 2014

"boost/signals.hpp" is not used in the package and since Boost 1.56.0 is
considered unmaintained and deprecated.

warning: #warning "Boost.Signals is no longer being maintained and
is now deprecated. Please switch to Boost.Signals2. To disable this
warning message, define BOOST_SIGNALS_NO_DEPRECATION_WARNING." [-Wcpp]

The patch removes the header.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

"boost/signals.hpp" is not used in the package and since Boost 1.56.0 is
considered unmaintained and deprecated.

    warning: #warning "Boost.Signals is no longer being maintained and
    is now deprecated. Please switch to Boost.Signals2. To disable this
    warning message, define BOOST_SIGNALS_NO_DEPRECATION_WARNING." [-Wcpp]

The patch removes the header.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_3_X.

Remove not needed and deprecated Boost.Signals header

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Nov 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
Remove not needed and deprecated Boost.Signals header
@cmsbuild cmsbuild merged commit f6a0536 into cms-sw:CMSSW_7_3_X Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants