New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std:: not boost:: thread handling classes #6407
Use std:: not boost:: thread handling classes #6407
Conversation
Given that C++11 now has a full set of thread safety and thread classes it is more portable to use those then to use the boost equivalent.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X. Use std:: not boost:: thread handling classes It involves the following packages: FWCore/MessageLogger @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Use std:: not boost:: thread handling classes
@Dr15Jones I think, this might have broken Darwin/OSX IBs:
|
Given that C++11 now has a full set of thread safety and thread classes it is more portable to use those then to use the boost equivalent.
The static analyzer knows about std::mutex but not boost::mutex. Instead of changing the static analyzer I figured it was better to 'modernize' the code.