Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std:: not boost:: thread handling classes #6407

Merged
merged 1 commit into from Nov 14, 2014

Conversation

Dr15Jones
Copy link
Contributor

Given that C++11 now has a full set of thread safety and thread classes it is more portable to use those then to use the boost equivalent.

The static analyzer knows about std::mutex but not boost::mutex. Instead of changing the static analyzer I figured it was better to 'modernize' the code.

Given that C++11 now has a full set of thread safety and thread classes it is more portable to use those then to use the boost equivalent.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_3_X.

Use std:: not boost:: thread handling classes

It involves the following packages:

FWCore/MessageLogger
FWCore/MessageService
FWCore/Utilities
Utilities/StorageFactory

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 14, 2014
Use std:: not boost:: thread handling classes
@cmsbuild cmsbuild merged commit 08c4a11 into cms-sw:CMSSW_7_3_X Nov 14, 2014
@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor

davidlt commented Nov 17, 2014

@Dr15Jones I think, this might have broken Darwin/OSX IBs:

Utilities/StorageFactory/src/StorageAccount.cc:16:26: error: 'gettimeofday' was not declared in this scope

@Dr15Jones Dr15Jones deleted the switchBoostMutexToStdMutex branch January 23, 2015 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants