Templated SoftLeptonTagInfo + PAT support for CandSoftLeptonTagInfo #6412
Conversation
|
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X. Templated SoftLeptonTagInfo + PAT support for CandSoftLeptonTagInfo It involves the following packages: DataFormats/BTauReco @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
| @@ -280,7 +280,7 @@ reco::SoftLeptonTagInfo SoftLepton::tag ( | |||
|
|
|||
| const GlobalVector jetAxis = refineJetAxis( jet, tracks, lepton->first ); | |||
| const math::XYZVector axis( jetAxis.x(), jetAxis.y(), jetAxis.z()); | |||
| if (DeltaR(lepton_momentum, axis) > m_deltaRCut) | |||
| if (ROOT::Math::VectorUtil::DeltaR(lepton_momentum, axis) > m_deltaRCut) | |||
There was a problem hiding this comment.
Involving ROOT here is unnecessary (CMSSW/DataFormats/Math/interface/deltaR.h, CMSSW/CommonTools/UtilAlgos/interface/DeltaR.h) and it is faster to use DeltaR2. Also, don't call this function twice (see 8 lines below).
There was a problem hiding this comment.
Switched to Geom::deltaR from DataFormats/GeometryVector/interface/VectorUtil.h which is really the same as reco::deltaR from DataFormats/Math/interface/deltaR.h. Also, introduced a local deltaR variable so that the function call is done only once.
|
@cmsbuild please test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
…from-CMSSW_7_3_0_pre2 Templated SoftLeptonTagInfo + PAT support for CandSoftLeptonTagInfo
ferencek
deleted the
TemplatedSoftLeptonTagInfo_from-CMSSW_7_3_0_pre2
branch
SoftLeptonTagInfo has been templated to support candidate-based SoftLeptonTagInfo. This will allow the existing soft lepton taggers to fully support MiniAOD. The PAT support for CandSoftLeptonTagInfo has also been included.
The code changes implemented in this PR should be completely transparent to the standard reconstruction. The attached plots show the performance of the existing soft muon and soft electron taggers before and after the changes.
SET (soft electron tagger)
SMT (soft muon tagger)
