Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in CtfSpecialSeedGenerator ocurring at run boundaries (73X version of #6418 ) #6419

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 15, 2014

move theRegionProducer delete to the destructor
fixes problems online
discussed in
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3395/2/1/1/2/1.html

tested in CMSSW_7_2_1_patch1 using the online DQM setup (crash is gone) and then with short matrix to see no differences in output as expected.

same code diff as in #6418

@slava77 slava77 changed the title fix crash in CtfSpecialSeedGenerator occuring at run boundaries (73X version of #6418 ) fix crash in CtfSpecialSeedGenerator ocurring at run boundaries (73X version of #6418 ) Nov 15, 2014
@slava77
Copy link
Contributor Author

slava77 commented Nov 15, 2014

+1

for #6419 a92b1ac
based on tests in #6418

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 15, 2014
…-runTrans-ctfSpecial

 fix crash in CtfSpecialSeedGenerator ocurring at run boundaries (73X version of #6418 )
@cmsbuild cmsbuild merged commit f332337 into cms-sw:CMSSW_7_3_X Nov 15, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants