Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premix partial 141115 p3 #6431

Merged
merged 4 commits into from Nov 18, 2014

Conversation

davidlange6
Copy link
Contributor

Much of premixing forward port from 70x release cycle by Mike including code cleanup.
Identity in standard workflows checked at level of 200 events of wf25203 unless I missed something.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_3_X.

Premix partial 141115 p3

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
DataFormats/SiStripCommon
EventFilter/SiStripRawToDigi
RecoLocalTracker/SiStripZeroSuppression
SLHCUpgradeSimulations/Configuration
SimCalorimetry/CaloSimAlgos
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalTrigPrimProducers
SimGeneral/DataMixingModule
SimGeneral/MixingModule
SimTracker/SiStripDigitizer

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @StoyanStoynev, @slava77, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @nickmccoll, @jlagram, @wmtan, @makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @appeltel, @cnuttens, @prolay, @venturia, @gpetruc, @cerati, @argiro, @threus, @dgulhan, @LBeck this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 16, 2014

@cmsbuild
are the jenkins tests running already?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 17, 2014

Just for a reference: the SiStrip changes (apparently the only RECO changes) were in #5952

@StoyanStoynev
Copy link
Contributor

+1
For 137a589.
The RECO part of the PR is identical to the one in #5952 (70X) which was signed off. Also jenkins here show no difference in monitored quantities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants