Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of oracle for plugins, 72x version #6465

Merged
merged 4 commits into from Nov 19, 2014

Conversation

apfeiffer1
Copy link
Contributor

... as they are only needed for online, not in the plugins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

remove use of oracle for plugins, 72x version

It involves the following packages:

CondTools/Hcal

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor Author

+1

On Tue, Nov 18, 2014 at 10:31 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @apfeiffer1
https://github.com/apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

remove use of oracle for plugins, 72x version

It involves the following packages:

CondTools/Hcal

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo you are the release manager for
this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#6465 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

we also need this for 73X.

@apfeiffer1
Copy link
Contributor Author

hmm ... I thought I updated the corresponding PR (#6463) ... maybe the bot
did not realise it yet ?

On Wed, Nov 19, 2014 at 9:20 AM, Malik Shahzad Muzaffar <
notifications@github.com> wrote:

we also need this for 73X.


Reply to this email directly or view it on GitHub
#6465 (comment).

Thanks,
cheers, andreas

@smuzaffar
Copy link
Contributor

#6463 has been merged/closed and it only contains your changes for the
plugin BuildFile.

On 11/19/2014 10:07 AM, Andreas Pfeiffer wrote:

hmm ... I thought I updated the corresponding PR (#6463) ... maybe the
bot
did not realise it yet ?

On Wed, Nov 19, 2014 at 9:20 AM, Malik Shahzad Muzaffar <
notifications@github.com> wrote:

we also need this for 73X.


Reply to this email directly or view it on GitHub
#6465 (comment).

Thanks,
cheers, andreas


Reply to this email directly or view it on GitHub
#6465 (comment).

@apfeiffer1
Copy link
Contributor Author

ah, I see that the other PR was already merged when I pushed the latest updates, sorry for overlooking this. PR #6489 takes care of this for 73x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants