Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of "PF cluster isolation for muons + TimeCleaned RecHit producer." #6470

Merged
merged 15 commits into from Nov 26, 2014

Conversation

HuguesBrun
Copy link
Contributor

This PR is the back-port in 72 of the PR #6266. To prevent the merge conflict to happen, it is made on the top of #5964
This PR will add the producers and filters to have the PF cluster isolation on muons at HLT + a filter on the ECAL recHits timing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_2_X.

backport of "PF cluster isolation for muons + TimeCleaned RecHit producer."

It involves the following packages:

Calibration/EcalAlCaRecoProducers
DataFormats/RecoCandidate
HLTrigger/Egamma
HLTrigger/HLTfilters
HLTrigger/special
RecoEgamma/EgammaHLTProducers
RecoMuon/L3MuonIsolationProducer

@perrotta, @cmsbuild, @diguida, @fwyzard, @cerminar, @Martin-Grunewald, @nclopezo, @rcastello, @StoyanStoynev, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @argiro, @bellan, @lgray, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

RECO, what is holding up your signature on this PR? This is a backport fo #6266 ...

@davidlange6
Copy link
Contributor

Seems the PR changed only yesterday, no?

On Nov 26, 2014, at 6:01 AM, Martin Grunewald <notifications@github.commailto:notifications@github.com> wrote:

RECO, what is holding up your signature on this PR? This is a backport fo #6266#6266 ...


Reply to this email directly or view it on GitHubhttps://github.com//pull/6470#issuecomment-64518854.

@Martin-Grunewald
Copy link
Contributor

....yes, due to a rebase because it does not get integrated....

@perrotta
Copy link
Contributor

@StoyanStoynev wrote in the other PR (#6538) about this one:

@ktf would you wait few hours for the new release - Slava was testing this PR so he'd better comment. Alternatively I can do it but he would know most of the details here.

Hopefully, Slava will not need a few hours for it: this PR is identical to #6266, already merged in 73X, and also identical to the one reco already signed here one week ago (modulo the last rebase)...

@ktf
Copy link
Contributor

ktf commented Nov 26, 2014

Ok.

On Wed Nov 26 2014 at 11:16:42 AM perrotta notifications@github.com wrote:

@StoyanStoynev https://github.com/StoyanStoynev wrote in the other PR (
#6538 #6538) about this one:

@ktf https://github.com/ktf would you wait few hours for the new
release - Slava was testing this PR so he'd better comment. Alternatively I
can do it but he would know most of the details here.

Hopefully, Slava will not need a few hours for it: this PR is identical to
#6266 #6266, already merged in 73X,
and also identical to the one reco already signed here one week ago (modulo
the last rebase)...


Reply to this email directly or view it on GitHub
#6470 (comment).

@slava77
Copy link
Contributor

slava77 commented Nov 26, 2014

+1

for #6470 5d13be0
the code increments are the same as already signed in #6470 as of be88cde

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

ktf added a commit that referenced this pull request Nov 26, 2014
backport of "PF cluster isolation for muons + TimeCleaned RecHit producer."
@ktf ktf merged commit ea28e38 into cms-sw:CMSSW_7_2_X Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants